Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial negative indice support in v4 #146

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

zqzten
Copy link
Contributor

@zqzten zqzten commented Jul 8, 2021

Currently the negative indice support in v4 is "partial" (only implemented for add/remove op to JSON array) so that a get/set op with negative indice will result in panic.

This PR fixed this issue and also added a general gitignore for the project.

@zqzten
Copy link
Contributor Author

zqzten commented Aug 24, 2021

Kindly ping @evanphx for some feedback?

@evanphx
Copy link
Owner

evanphx commented Oct 20, 2021

Sorry for the delay, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants